Skip to content

chore(web): Fix start:web #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

chore(web): Fix start:web #488

merged 1 commit into from
Nov 18, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 10, 2020

Summary

The example app is currently broken due to @react-native-async-storage/async-storage not being resolved correctly.

Resolves #472.

Test Plan

  1. Run yarn.
  2. Run yarn start:web.
  3. Once the dev server is running, press w to open the project in browser.
  4. The example should work as expected.

@tido64 tido64 added the platform: web This is web specific label Nov 10, 2020
@tido64 tido64 requested a review from krizzu November 10, 2020 23:46
krizzu
krizzu approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, :shipit:

@tido64 tido64 merged commit 5bb27e9 into master Nov 18, 2020
@tido64 tido64 deleted the tido/fix-start-web branch November 18, 2020 15:41
@krizzu
Copy link
Member

krizzu commented Jan 18, 2021

🎉 This PR is included in version 1.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
platform: web This is web specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web: Example app is broken
2 participants
@tido64 @krizzu