Skip to content

Resolved missing Deploy issue #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

chiaramooney
Copy link
Contributor

Summary:

Fixes #6239

Resolving error message "ReactNativeAsyncStorage.vcxproj : error MSB4057: The target "Deploy" does not exist in the project" by adding target with Deploy name.

Test Plan:

To test, add module to React Native app with Windows support. Run app in Windows emulator. Change is successful if app loads in Windows emulator without errors.

@@ -146,11 +146,12 @@
<ImportGroup Label="ExtensionTargets">
<Import Project="$(SolutionDir)packages\Microsoft.Windows.CppWinRT.2.0.190730.2\build\native\Microsoft.Windows.CppWinRT.targets" Condition="Exists('$(SolutionDir)packages\Microsoft.Windows.CppWinRT.2.0.190730.2\build\native\Microsoft.Windows.CppWinRT.targets')" />
</ImportGroup>
<Target Name="Deploy"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: formatting

@chiaramooney chiaramooney changed the title resolved missing Deploy issue Resolved missing Deploy issue Oct 16, 2020
@tido64 tido64 linked an issue Oct 16, 2020 that may be closed by this pull request
@tido64 tido64 merged commit 2f504f3 into react-native-async-storage:master Oct 16, 2020
@krizzu krizzu mentioned this pull request Oct 24, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use with windows.
4 participants