ci(iOS): Fix yarn install failing with Xcode 12 #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/fix-xcode12-build
branch
3 times, most recently
from
d43a4c8 to
abf5ade
Compare
tido64
commented
Oct 15, 2020
tido64
force-pushed
the
tido/fix-xcode12-build
branch
5 times, most recently
from
e17c182 to
f64c945
Compare
tido64
commented
Oct 21, 2020
tido64
changed the title
tido64
force-pushed
the
tido/fix-xcode12-build
branch
from
f64c945 to
ea6ed78
Compare
Note that this does not fix tests failing to run on iOS 14. EarlGrey, which is what Detox depends on, crashes when run on iOS 14 (google/EarlGrey#1447). We may be required to bump to latest Detox to solve this issue, but it will require more work on our side.
tido64
force-pushed
the
tido/fix-xcode12-build
branch
from
ea6ed78 to
cf8b9b9
Compare
krizzu
reviewed
Oct 22, 2020
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
yarn installfails because Detox fails to build with Xcode 12.Resolves #454.
Test Plan:
git clean -dfqxyarn