Skip to content

v2 improvements - web #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2020
Merged

v2 improvements - web #284

merged 5 commits into from
Jan 29, 2020

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Jan 19, 2020 •
edited
Loading

Summary:

Next round of improvements for v2:

Test Plan:

Green CI.

@krizzu krizzu added v2 labels Jan 19, 2020
@krizzu krizzu changed the base branch from LEGACY to master January 19, 2020 13:50
@krizzu krizzu changed the title V2 enhancement v2 Web Storage enhancements Jan 19, 2020
@krizzu krizzu changed the title v2 Web Storage enhancements v2 improvements Jan 19, 2020
@vomchik
Copy link

vomchik commented Jan 19, 2020 •
edited
Loading

@krizzu Could you publish RC2, please. I need your fix with __DEV__ variable. Thanks.

@krizzu
Copy link
Member Author

krizzu commented Jan 20, 2020

@krizzu Could you publish RC2, please. I need your fix with __DEV__ variable. Thanks.

Yes, I plan to do this later today

@vomchik
Copy link

vomchik commented Jan 20, 2020

Thanks a lot!

@krizzu krizzu mentioned this pull request Jan 21, 2020
Closed
@krizzu
Copy link
Member Author

krizzu commented Jan 22, 2020

Thanks a lot!

Sorry, seems like I'm bit delayed.

@krizzu krizzu removed the WIP label Jan 23, 2020
@krizzu krizzu changed the title v2 improvements v2 improvements - web Jan 23, 2020
@krizzu krizzu merged commit 12669a0 into master Jan 29, 2020
@vomchik
Copy link

vomchik commented Jan 29, 2020

Thanks!

@vomchik
Copy link

vomchik commented Feb 3, 2020

@krizzu Hi! Any news about the new RC?

@krizzu krizzu deleted the v2-enhancement branch February 3, 2020 12:18
@krizzu
Copy link
Member Author

krizzu commented Feb 4, 2020

@vomchik
Just released RC.2!

@soroushm
Copy link

AsyncStorage removed from react-native-web since version 12
https://github.com/necolas/react-native-web/releases

@soroushm
Copy link

soroushm commented Mar 22, 2020 •
edited
Loading

Finally got the right package for web

   ` '@react-native-community/async-storage': 'redux-persist/lib/storage',`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krizzu @vomchik @soroushm