Prefer PlatformLocalStorage Over Other Native Modules #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently try to load builtin native modules before trying to fallback to platform provided native modules. Reversing this order allows the platform to provide the AsyncStorage implementtion even if on a platform that async-storage already supports. This ability can be useful in hosted scenarios where we may want more control over how data for an individual React Native instance is stored.
|
Hey @NickGerleman
Our initial thoughts were that cc @tido64 |
|
Oh wow, I didn't actually realize that draft PRs were public. I originally made this just to run CI for a change we were playing with. I can still publish this if we like the idea of the change though. |
|
@NickGerleman Thanks, going to release new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently try to load builtin native modules before trying to
fallback to platform provided native modules. Reversing this order
allows the platform to provide the AsyncStorage implementtion even if
on a platform that async-storage already supports. This ability can
be useful in hosted scenarios where we may want more control over how
data for an individual React Native instance is stored.
This should be entirely unneeded for AsyncStorageV2 since we have IStorageBackend.