Gracefully handle the case where inputs to multiSet are not of the type Array<Array<String>>

[bushshrub]

Motivation

At present, React Native applications will crash when AsyncStorage.multiSet is called with invalid arguments, for example, AsyncStorage.multiSet(['a', 'b'], ['c', 'd']). Note that in this case, there are 2 arguments provided to the function for the keyValuePairs required to store as data. However, this happens to be a typo and the developer actually intended to wrap it with square brackets, but failed to do so.

Since there is no error thrown, the application literally just crashes and makes debugging almost impossible.

Description

An exception should be raised when the type of the inputs to the keyValuePairs argument of multiSet is incorrect, instead of simply letting the application crash.

New feature implementation

Type comparison of the first argument would be crucial in correcting this.

[kiranjd]

I would like to work on this

[tido64]

@kiranjd: Please go ahead and submit a PR 😃

[bushshrub]

@kiranjd Another possibility would be to handle the case where multiSet is called with n arguments

[kiranjd]

@xiurobert That approach might not work as the second arg could be passed as well.
I'm thinking of checking if the second type is an array. If so, show the relevant warning message. What do you think?

[kiranjd]

As I looked to add regression tests, I see that multiSet, muliGet, and a few others are not covered in e2e tests. Hence, I have skipped tests as it would be outside the scope for the current PR.

Maybe we can create adding tests as issues and then add them incrementally?

[krizzu]

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀