refactor: fix typecheck errors and add script execution to CI #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
marcalexiei
force-pushed
the
typecheck
branch
from
48de0bb to
e5ff202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1098.
Note
Based upon #1102 (I marked this PR as draft, will rebase and make it ready for review after #1102 is merged).addedtypecheckscript toci.ymlcheckstypecheck:ciscript toci.ymlchecksI'm not using directly
typecheckscript becausesrc/pages/[...slug].tsxfile requires types fromcontentlayer/generatedwhich are available only afternext build.To resolve this issue I created a new
typecheck:ciscript that runsnext build --no-lintbeforetsc --noEmitLet me know if you want that this explanation should be added to
CONTRIBUTING.mdfor future reference.