Skip to content

refactor: fix eslint errors #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const ERROR = 2
/* eslint-enable @typescript-eslint/no-unused-vars */

module.exports = {
reportUnusedDisableDirectives: true,
parser: "@typescript-eslint/parser",
parserOptions: {
ecmaVersion: 2020,
Expand Down Expand Up @@ -42,5 +43,7 @@ module.exports = {
// jsx-ally
"jsx-a11y/no-onchange": WARN,
"import/no-anonymous-default-export": OFF,
// next
"@next/next/no-img-element": OFF,
},
}
13 changes: 9 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,16 @@ env:
HUSKY: 0

jobs:
ci:
name: CI
check:
name: Run ${{ matrix.script }} code check
runs-on: ubuntu-latest
timeout-minutes: 15

strategy:
fail-fast: true
matrix:
script: [format, lint]

steps:
- name: Checkout repo
uses: actions/checkout@v4
Expand All @@ -34,6 +39,6 @@ jobs:
shell: bash
run: pnpm install --frozen-lockfile

- name: Format
- name: Run ${{ matrix.script }}
run: |
pnpm run format
pnpm run ${{ matrix.script }}
12 changes: 7 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@
},
"devDependencies": {
"@next/bundle-analyzer": "^13.4.5",
"@types/react": "^18.3.11",
"@types/react-helmet": "^6.1.6",
"@typescript-eslint/eslint-plugin": "^5.59.11",
"@typescript-eslint/parser": "^5.59.11",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
"cross-env": "^7.0.3",
"eslint": "^8.42.0",
"eslint": "^8.57.1",
"eslint-config-next": "^13.4.5",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-jsx-a11y": "^6.7.1",
Expand All @@ -47,7 +48,7 @@
"husky": "^8.0.3",
"lint-staged": "^13.2.2",
"prettier": "^3.4.2",
"typescript": "^5.1.3"
"typescript": "^5.6.3"
},
"keywords": [
"react-hook-form",
Expand All @@ -60,7 +61,8 @@
"dev": "next dev",
"format": "prettier . --check",
"format:fix": "prettier . --write",
"lint": "next lint --fix",
"lint": "next lint",
"lint:fix": "next lint --fix",
"now-build": "pnpm run build",
"start": "next start",
"typecheck": "tsc --noEmit",
Expand Down
Loading
Loading