-
Notifications
You must be signed in to change notification settings - Fork 430
Row expand animation v2 #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Row expand animation v2 #1289
Conversation
"appear" was no longer being triggered, changed it to "active" instead
- Now supports any content height - Smoother animation
- Animation is on by default - 'animate' property in expandRow prop
Hi! Was this already merged in the latest build in NPM? Thanks! |
@keanpaderes No, the PR is still open |
Sorry, I was busy recently. I will merge this ASAP, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @YassienW boss, there are two major issues
- when you expand a row then click it again to collapse, then an error throw.
- I guess the new animation isn't work, you can try it even
animation
is true as default.
Are you doing the testing on storybook? I tested on the row expand stories (on chrome) and they work perfectly fine. |
@YassienW yes, I test it on chrome by storybook! |
@AllenFang Is there any update on this ? Can you show us the error you got ? It's really frustrating not being able to disable animations when they are not working properly. |
@rodricarranza Can you help by testing it on your end? It's very weird that it's working fine on my end but @AllenFang is having issues, not sure how to replicate. |
Hi, is there any update on this? Could I help in any way? |
Improved row expansion animation (#912):
animate
prop to disable animation (true by default)Added storybook page for
animate
propFurther testing would be appreciated.