Skip to content

Row expand animation v2 #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

YassienW
Copy link
Contributor

Improved row expansion animation (#912):

  • Smoother animation
  • Can handle any content height without looking weird
  • Added animate prop to disable animation (true by default)

Added storybook page for animate prop

Further testing would be appreciated.

"appear" was no longer being triggered, changed it to "active" instead
- Now supports any content height
- Smoother animation
- Animation is on by default
- 'animate' property in expandRow prop
@YassienW YassienW changed the title Animation v2 Row expand animation v2 Mar 13, 2020
@keanpaderes
Copy link

Hi! Was this already merged in the latest build in NPM? Thanks!

@YassienW
Copy link
Contributor Author

@keanpaderes No, the PR is still open

@AllenFang
Copy link
Member

Sorry, I was busy recently. I will merge this ASAP, thanks

@AllenFang AllenFang added this to the s1 milestone Apr 11, 2020
Copy link
Member

@AllenFang AllenFang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YassienW boss, there are two major issues

  1. when you expand a row then click it again to collapse, then an error throw.
  2. I guess the new animation isn't work, you can try it even animation is true as default.

@YassienW
Copy link
Contributor Author

Are you doing the testing on storybook? I tested on the row expand stories (on chrome) and they work perfectly fine.

@AllenFang
Copy link
Member

@YassienW yes, I test it on chrome by storybook!

@rodricarranza
Copy link

@AllenFang Is there any update on this ? Can you show us the error you got ? It's really frustrating not being able to disable animations when they are not working properly.

@YassienW
Copy link
Contributor Author

YassienW commented Jul 1, 2020

@rodricarranza Can you help by testing it on your end? It's very weird that it's working fine on my end but @AllenFang is having issues, not sure how to replicate.

@Nautman
Copy link

Nautman commented Mar 25, 2021

Hi, is there any update on this? Could I help in any way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants