Skip to content

Fix/aria label headers #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2020
Merged

Fix/aria label headers #1248

merged 3 commits into from
Feb 16, 2020

Conversation

Michael-Hanley
Copy link
Contributor

  • Adds aria label to describe if the column is sortable
  • Describes new sort direction when sort direction changes
  • Describes pre-existing sort if tabbed to and a sort is already set

#1247

AllenFang
AllenFang approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@AllenFang AllenFang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllenFang AllenFang merged commit 2d418d8 into react-bootstrap-table:develop Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenFang AllenFang AllenFang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-Hanley @AllenFang