Custom Pagination With Search Not working correctly

[eyle]

Hello,

I don't know if we should call it an issue , but here is the problem i encountered:
When filtering for a specific value , pagination works fine (It shows the right number of filtered page and the element filtered is shown in the table) .
The problem happens when data changes while filtering is still active(showing 1 page and 1 items that matches our filter) , when we load new data while search is active , a problem occurs (Number of pages becomes incorrect ) [Instead of having one page wich is the correct result since filter is still active , we got X pages that relates data length]

Steps to reproduce:

• Use storyBook example : https://react-bootstrap-table.github.io/react-bootstrap-table2/storybook/index.html?selectedKind=Pagination&selectedStory=Custom%20Pagination%20with%20Search&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel
• Search on element (In my case i used 0 ) => Example show 1 Page(everything is good)
• Load Another Data (Click twice on Load Another data)
• Pagination Is showing 2 pages while filter is still Set( i think it only occurs when having the same data shown fetched again and again)
• Worst when we got to second page , blank lines are displayed (See Images Below)

This is really annoying when there are formater on rows , this will display errors because when accessing rows element(Errors will be displayed since key doesn't )

[AllenFang]

@eyle I will check this out. It could be a bug or could be not(Maybe just the wrong code for example )

[Vinaythegreat]

Is there any hotfix now ?

[eyle]

Hello back ,

This issue also hapened to me when using actions buttons in table Cell, let me explain this:
I had formatter function on one of the cell(Called Actions) that displays icons[Delete,Add,etc...) (When clicked they launched a reactstrap Modal in which i had several forms ) , I noticed that when search is still active and modal is toggled/opened , the bug occur (We got pagination back setto the total of rows despite the fact that filter is still ON).
I had fixed this by preventing the Table from rerendering by using (ShouldComponentUpdate lifecycle ) which it wasn't necessary in my case (The rerender).

I'm saying this because i think that the issue occur when Rerender is trigered by react and search is still active which causes to have the wrong pagination(Calculated again but ignoring search filter) , i hope it helps :) .

Thx Again for Bootstrap Table (Helped me a lot [everything is present in it ])

[AllenFang]

sorry for lately reply, I will be back to this project after my crazy busy hell. if everything ok, i will come back in the mid of Jun.

[AllenFang]

So far this case only happen when load the same data twice. This issue maybe hard to fix so far under current design. so be patient, I will fix it with best way