Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

Provide better dark mode support #93

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Provide better dark mode support #93

merged 2 commits into from
Mar 27, 2023

Conversation

rawilk
Copy link
Owner

@rawilk rawilk commented Mar 27, 2023

This PR introduces a Tailwind plugin which will provide better dark mode support than the dark-mode.css file currently does. It will work for the following kinds of tailwind configs for the darkMode setting:

module.exports = {
    darkMode: 'media',
};
module.exports = {
    darkMode: 'class',
};
module.exports = {
    darkMode: ['class', '.is-dark'],
};

The dark-mode.css class is getting removed in this PR, and any other references to dark mode in any css file will also be removed. Essentially, dark mode will be opt-in.

@rawilk rawilk merged commit 6b02836 into main Mar 27, 2023
@rawilk rawilk deleted the better-dark-mode-support branch March 27, 2023 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant