Skip to content

Revert "LED" to Pin 25 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

tobybroberts
Copy link
Contributor

No description provided.

@aallan aallan merged commit 35f9a54 into raspberrypi:master Mar 1, 2023
@kilograham
Copy link
Contributor

out of curiosity why was this reverted?

@lurch
Copy link
Contributor

lurch commented Mar 2, 2023

Because it doesn't work on Pico W, so we thought if we leave it as 25 it makes it more obvious that it only works on Pico; whereas "LED" might imply that it works on both Pico and Pico W.

@kilograham
Copy link
Contributor

umm.. Pico W was the entire reason for adding "LED" to MP for RP2040 in the first place, when did it get broken? seems like someone ought to fix it.

@dpgeorge
Copy link

dpgeorge commented Mar 2, 2023

The "LED" string does work on Pico W, but the example here is about PWM, and PWM doesn't work on that LED.

>>> machine.PWM(machine.Pin("LED"))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: expecting a regular GPIO Pin

@lurch
Copy link
Contributor

lurch commented Mar 2, 2023

Yes, sorry I should have clarified that the "LED" string works for regular-GPIO on both Pico and Pico W, but doesn't work with PIO or PWM on Pico W. See also #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants