FIX: Error when generating a controller. #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the main issue of #77 . Other issues noted there, we will fix later since they are less pressing atm :) |
This PR fixes error on the controller generation: `bin/rails g controller Home index` Since, I'd to override rails scaffold controller to work with rails 6, I needed to configure rails controller generator also.
dixpac
force-pushed
the
dix/fix_controller_generators_bug
branch
from
974d024 to
f7cfd37
Compare
|
Can you fix up #77? |
|
I will try, Main issue is that I've "monkey-patched" default rails generators in order to have the partial for rails 6, and that opened panadora's box and I'm not sure how much can we go with this monkey patch in relation with other engines such as view_component. One thing I'm thinking we could do, but not sure if you are up for that is to have the partial on rails 7+ and no partial for rails 6 (UI design will stay the same)? //index.html.erb
<% if Rails.version < 7 %>
// loop with with the divs
<% end %> |
|
Yeah, sounds like a better path to split them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error on the controller generation:
bin/rails g controller Home indexSince, I'd to override rails scaffold controller to work with rails 6, I
needed to configure rails controller generator also.