Doesn't reload after secrets.yml changes

[morgoth]

I'm not sure if this should be in spring itself or should developer add it to custom watch command. config/secrets.yml is one of default files in rails 4.1 so maybe it should be included out of the box. What do you think?

[jonleighton]

Yep, I think it makes sense for it to be watched out the box since it's a Rails default.

[morgoth]

@jonleighton I tried to add test but I'm getting random failures/errors on my local machine, llike:

  7) Failure:
AppTest#test_test_changes_are_picked_up [/home/wojtek/Projects/spring/test/acceptance/app_test.rb:91]:
expected successful exit status

$ bin/rake test /home/wojtek/Projects/spring/test/apps/tmp/test/controllers/posts_controller_test.rb
--- stderr ---
/home/wojtek/Projects/spring/test/apps/tmp/db/schema.rb doesn't exist yet. Run `rake db:migrate` to create it, then try again. If you do not intend to use a database, you should instead alter /home/wojtek/Projects/spring/test/apps/tmp/config/application.rb to limit the frameworks that will be loaded.
--- log ---
[2014-05-17 22:23:49 +0200] [4026] [server] started on /tmp/spring/f6869a9ee2a05d144ccf1a7991e4f5b8
[2014-05-17 22:23:49 +0200] [4026] [server] accepted client
[2014-05-17 22:23:49 +0200] [4026] [server] running command rake
[2014-05-17 22:23:49 +0200] [4023] [client] sending command
[2014-05-17 22:23:49 +0200] [4026] [application_manager:test] child not running; starting
[2014-05-17 22:23:49 +0200] [4030] [application:test] initialized -> running
[2014-05-17 22:23:49 +0200] [4030] [application:test] got client
[2014-05-17 22:23:49 +0200] [4030] [application:test] preloading app
[2014-05-17 22:23:50 +0200] [4030] [application:test] forked 4049
[2014-05-17 22:23:50 +0200] [4026] [application_manager:test] got worker pid 4049
[2014-05-17 22:23:50 +0200] [4023] [client] got pid: 4049
[2014-05-17 22:23:50 +0200] [4030] [application:test] 4049 exited with 1
[2014-05-17 22:23:50 +0200] [4023] [client] got exit status 1

Also I'm not sure how to test it properly, since I didn't find similar tests for initializers and database config files.

[AlexVPopov]

Sorry for bothering, but in Rails 4.1.5 the issue is still there. Should I do something additional to remove the problem or should I wait for a next version of Rails, which will pickup this PR?

[morgoth]

@AlexVPopov new version of gem still wasn't released, so you can pull it from github or add Spring.watch "config/secrets.yml" to your config/spring.rb meanwhile