Automatically inserts Turbo Stream responses #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelolx
reviewed
Jun 3, 2021
excid3
force-pushed
the
handle-turbo-stream-on-success
branch
2 times, most recently
from
67d5b22 to
7fb5b3d
Compare
This makes it easier for users so they don't have to insert the Turbo Stream HTML into the body.
excid3
force-pushed
the
handle-turbo-stream-on-success
branch
from
7fb5b3d to
f28a6d5
Compare
marcelolx
approved these changes
Jun 4, 2021
|
@marcelolx Thanks! ✌️❤️ On a related note... do you think we should modify Turbo to automatically set |
|
Yes, definitely want to set window.Turbo. We have the same issue at Basecamp. In fact, we do that in our pack setup: const { Turbo } = require("@hotwired/turbo-rails")
window.Turbo = Turbo |
|
@marcelolx I started one already, just need to test it. hotwired/turbo#280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user may not realize this how to execute Turbo Stream actions in the response, so it is nice if we can take care of it for them. By automatically inserting the Turbo Stream responses into the body, we can apply those operations automatically for the user.
I couldn't think of any situations where you might want to disable this, but we could add an option to disable it if needed.
Thoughts on this or how it can be improved?
cc @dhh