Skip to content

Fix renderTurboStream return #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fix renderTurboStream return #18

merged 1 commit into from
Jun 9, 2021

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Jun 9, 2021

#15 incorrectly refactored the renderTurboStream method so that it always returns a rejected Promise.

This fixes that by returning properly when the contentType is correct.

marcelolx
marcelolx reviewed Jun 9, 2021
View reviewed changes
@excid3 excid3 force-pushed the fix-render-turbo-stream branch from bab2820 to 8144cc3 Compare June 9, 2021 14:20
@excid3
Copy link
Contributor Author

excid3 commented Jun 9, 2021

And updated @marcelolx 👍

@marcelolx marcelolx merged commit 2518291 into rails:main Jun 9, 2021
@marcelolx
Copy link
Collaborator

Thanks @excid3

@guillaumebriday
Copy link
Member

oops sorry @excid3, that is my fault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelolx marcelolx marcelolx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@excid3 @marcelolx @guillaumebriday