Skip to content

Add a note for whitelisted tags by default in the TargetScrubber #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Add a note for whitelisted tags by default in the TargetScrubber #110

merged 3 commits into from
Feb 9, 2021

Conversation

paul-mesnilgrente
Copy link
Contributor

See #109.

What do you think about the wording?

@s01ipsist
Copy link

IMHO, a deep link to https://github.com/flavorjones/loofah/blob/main/lib/loofah/html5/safelist.rb would be valuable

Copy link
Contributor

@kaspth kaspth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Needs a wording change, and the suggested deep link would also be good.

paul-mesnilgrente and others added 2 commits January 31, 2021 21:10
@paul-mesnilgrente
Copy link
Contributor Author

What do you think now?

@kaspth kaspth merged commit 1e64885 into rails:master Feb 9, 2021
@kaspth
Copy link
Contributor

kaspth commented Feb 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants