Added Bootstrap option #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this is awesome. |
DavidColby
reviewed
Sep 8, 2021
marcoroth
reviewed
Sep 8, 2021
added 3 commits
September 9, 2021 16:00
…r some reason. changed from '~bootstrap/scss/bootstrap' to '../../../node_modules/bootstrap/scss/bootstrap'
|
Awesome stuff @AndreyAzimov 🍻 |
added 7 commits
September 9, 2021 16:50
* main: Don't enhance test:prepare unless it exists (rails#9) Ensure bin/dev is executable (rails#8) Bump version for 0.1.4 Exclude .keep file from .gitignore Mention required npx version in readme Bump version for 0.1.3 Ensure port 3000 Bump version for 0.1.2 Add bin/dev to run multiple processes Update Readme: fix stylsheet tag method
Or Sprockets will try to install sassc!
|
Is this for webpacker use only ? Is it strange that there are specific framework options but only when using webpacker - especially when this is (rightly) not the default method now. sass bootstrap support with esm js imports would be a nice option (although pretty trivial to do manually) |
|
No, this does not require Webpacker. You can use it with either importmaps or jsbundling-rails. |
|
aah - I saw yarn being used and assumed it was webpacking - is yarn a base requirement for rails now ? |
|
Nope. Just a requiring for using node-based bundling tools. |
|
I found bootstrap 5 needs to go through autoprefixer or some styles don't work. I'm dragging in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run:
rails css:install:bootstrap