Skip to content

Primary key violation should result in RecordNotUnique error #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
#### Unreleased

#### Fixed

- [#940](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/940) Primary key violation should result in RecordNotUnique error

#### Changed

- ...

#### Added

- ...

## v6.1.1.0

[Full changelog](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/compare/v6.1.0.0...v6.1.1.0)
Expand Down
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ def translate_exception(e, message:, sql:, binds:)
case message
when /(SQL Server client is not connected)|(failed to execute statement)/i
ConnectionNotEstablished.new(message)
when /(cannot insert duplicate key .* with unique index) | (violation of unique key constraint)/i
when /(cannot insert duplicate key .* with unique index) | (violation of (unique|primary) key constraint)/i
RecordNotUnique.new(message, sql: sql, binds: binds)
when /(conflicted with the foreign key constraint) | (The DELETE statement conflicted with the REFERENCE constraint)/i
InvalidForeignKey.new(message, sql: sql, binds: binds)
Expand Down
8 changes: 8 additions & 0 deletions test/cases/adapter_test_sqlserver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,14 @@ class AdapterTestSQLServer < ActiveRecord::TestCase
"expected database #{db_config.database} to exist"
end

it "test primary key violation" do
Post.create!(id: 0, title: 'Setup', body: 'Create post with primary key of zero')

assert_raise ActiveRecord::RecordNotUnique do
Post.create!(id: 0, title: 'Test', body: 'Try to create another post with primary key of zero')
end
end

describe "with different language" do
before do
@default_language = connection.user_options_language
Expand Down