Rails 6.1: remove deprecation warnings #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be removed from Rails 6.2 Deprecation commit rails/rails@ab2d859
…6.2 (Use configs_for) Deprecation commit rails/rails@2a53fe6
…eprecated and will be no longer quoted as id value in Rails 6.2 Deprecation commit rails/rails@87886c9
…in Rails 6.2. To continue taking non-deterministic result, use / instead. Deprecation commit rails/rails@eec562d
mgrunberg
deleted the
issues/yellowspot/rails-6-1/remove-deprecation-warnings
branch
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
* DEPRECATION WARNING: allowed_index_name_length is deprecated and will be removed from Rails 6.2 Deprecation commit rails/rails@ab2d859 * DEPRECATION WARNING: [] is deprecated and will be removed from Rails 6.2 (Use configs_for) Deprecation commit rails/rails@2a53fe6 * DEPRECATION WARNING: Passing an Active Record object to directly is deprecated and will be no longer quoted as id value in Rails 6.2 Deprecation commit rails/rails@87886c9 * DEPRECATION WARNING: with / no longer takes non-deterministic result in Rails 6.2. To continue taking non-deterministic result, use / instead. Deprecation commit rails/rails@eec562d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with 4 deprecation warnings by looking at the deprecation commit and applying a similar update.
allowed_index_name_length is deprecated and will be removed from Rails 6.2(source rails/rails@ab2d859)[] is deprecated and will be removed from Rails 6.2 (Use configs_for)(source rails/rails@2a53fe6)Passing an Active Record object to directly is deprecated and will be no longer quoted as id value in Rails 6.2(source rails/rails@87886c9).reorder(nil) with .first / .first! no longer takes non-deterministic result in Rails 6.2. To continue taking non-deterministic result, use / instead.(source rails/rails@eec562d)