Rails 6.1 fixes: Use renamed connection_config method and rewrite coerced tests using unsafe raw SQL #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for using unsafe raw SQL in `ActiveRecord::Relation` methods has been removed. See rails/rails@317465a
|
Thanks for the contribution. |
mgrunberg
deleted the
issues/yellowspot/rails-6-1/use-renamed-connection-config-and-rewrite-coerced-tests
branch
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…rced tests using unsafe raw SQL (rails-sqlserver#882) * Use renamed ARTest.connfiguration_config method See more: rails/rails#38007 * rewrite coerced specs using unsafe raw SQL Support for using unsafe raw SQL in `ActiveRecord::Relation` methods has been removed. See rails/rails@317465a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes:
UnsafeRawSqlTestcoerced tests because unsafe raw SQL support was removed (see rails/rails@317465a)