Fix EagerLoadingTooManyIdsTest#test_preloading_too_many_ids
#786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rails/rails#36074, `in_clause_length` will no longer help the adapter to avoid complex query limitation, and will be removed from Rails code base (rails/rails#39057).
|
Thanks :) |
YehudaGold
added a commit
to YehudaGold/activerecord-sqlserver-adapter
that referenced
this pull request
Apr 28, 2020
wpolicarpo
pushed a commit
that referenced
this pull request
Apr 29, 2020
* update AttributeMethodsTest tests * clean AdapterTestWithoutTransaction coerce_tests! statement * update CalculationsTest tests * add coerced test for test_create_without_primary_key_no_extra_query * remove test_relation_merging_with_merged_symbol_joins_is_aliased__coerced fixed in rails/50684d15c6546d3050d93896612edd9c5a0fca62 * update test_sanitize_sql_like_example_use_case_coerced updated in rails/de2f1e073b37f98a99334a909b8bc29f36ad506b * remove coerce test_eager_loading_too_may_ids fixed in #786 * remove fixed coerce test test "column names are quoted when using #from clause and model has ignored columns" fixed in rails/d53b259a29e77a60a02e9c219661e19ef62ef9aa * remove coerce NumericDataTest tests tests been fiexd in active recorde * updete ChangeSchemaTest coerce tests * remove fixed test_scopes_honor_current_scopes_from_when_defined * add tests comment * clean lines spacing * fix test_typecast_attribute_from_select_to_true_coerced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rails/rails#36074,
in_clause_lengthwillno longer help the adapter to avoid complex query limitation, and will
be removed from Rails code base (rails/rails#39057).