Skip to content

Rails 6: Cache database version in schema cache #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

Rails 6: Cache database version in schema cache #752

merged 1 commit into from
Apr 1, 2020

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Apr 1, 2020 •
edited
Loading

Added method ActiveRecord::ConnectionAdapters::SQLServerAdapter#get_database_version to support rails/rails#35795

This fixes the ActiveRecord::ConnectionAdapters::SchemaCacheTest failing tests.

Before
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/669298290?utm_medium=notification&utm_source=github_status

6728 runs, 18648 assertions, 53 failures, 38 errors, 25 skips

After

6728 runs, 18636 assertions, 53 failures, 36 errors, 25 skips

@aidanharan
Added method to get database version
2e00595 
Method should be public
@aidanharan aidanharan force-pushed the database-version-fix branch from a148c35 to 2e00595 Compare April 1, 2020 12:58
@aidanharan aidanharan marked this pull request as ready for review April 1, 2020 13:12
@wpolicarpo wpolicarpo merged commit 9841e46 into rails-sqlserver:6-0-dev Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidanharan @wpolicarpo