Skip to content

Rails 6: Correctly retrieve Arel::Table in join queries #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Mar 30, 2020

Fix to correctly retrieve the Arel::Table when using a join query.

Solution taken from #704

Before
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/668693683?utm_medium=notification&utm_source=github_status

6728 runs, 18637 assertions, 53 failures, 43 errors, 25 skips

After
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/668832573?utm_medium=notification&utm_source=github_status

6728 runs, 18642 assertions, 53 failures, 39 errors, 25 skips

@aidanharan aidanharan changed the title WIP: Fix for table from statement join WIP: Correctly retrieve Arel::Table in join queries Mar 31, 2020
@aidanharan aidanharan marked this pull request as ready for review March 31, 2020 09:06
@aidanharan aidanharan changed the title WIP: Correctly retrieve Arel::Table in join queries Correctly retrieve Arel::Table in join queries Mar 31, 2020
@aidanharan aidanharan changed the title Correctly retrieve Arel::Table in join queries Rails 6: Correctly retrieve Arel::Table in join queries Mar 31, 2020
@wpolicarpo wpolicarpo merged commit ae1bccd into rails-sqlserver:6-0-dev Mar 31, 2020
@aidanharan aidanharan deleted the fix-table-from-statement-join branch March 31, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants