Skip to content

Fixed Ruff linter defaulting to python3.8 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fixed Ruff linter defaulting to python3.8 #37

merged 1 commit into from
Nov 8, 2023

Conversation

rosstitmarsh
Copy link
Contributor

@rosstitmarsh rosstitmarsh commented Nov 8, 2023

Ruff currently defaults to linting code as if it was Python 3.8, hence the tomllib import being moved in commit 7edb31c.

It can be specified with requires-python = ">= 3.12" in the [project] section of pyproject.toml, but since you are not using that section I used the Ruff specific option.

Copy link
Owner

@rafsaf rafsaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I wasn't aware that ruff is using py3.8 by default. I think I noticed this weird order change of "import tomllib", but I moved to doing something else and forgot about it.

Thanks a lot :P

@rafsaf rafsaf merged commit 32101f2 into rafsaf:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants