Skip to content

Makes Channel extend AutoCloseable #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2017
Merged

Makes Channel extend AutoCloseable #261

merged 1 commit into from
Apr 11, 2017

Conversation

venilnoronha
Copy link
Contributor

@venilnoronha venilnoronha commented Apr 11, 2017 •
edited by michaelklishin
Loading

This PR makes the Channel class extend AutoCloseable. Note that Channel cannot extend Closeable due to the throws TimedOutException declaration on Channel#close(). See #258 for additional details.

Please review and merge. I've signed and mailed the CLA.

Closes #258.

Thanks,
Venil

@michaelklishin michaelklishin self-assigned this Apr 11, 2017
@michaelklishin michaelklishin merged commit c49f714 into rabbitmq:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AutoCloseable in Channel
2 participants
@venilnoronha @michaelklishin