Skip to content

Update test_models.py #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Update test_models.py #940

merged 2 commits into from
Oct 12, 2024

Conversation

brianhou0208
Copy link
Contributor

Description

New decoder was added in #926, but I found that UPerNet & DeepLabV3Plus missed some tests.

This PR fixes some bugs and ensures that each decoder has been tested.

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@brianhou0208
Copy link
Contributor Author

Hi @qubvel ,
I think it's ready to merge.

Update

  • Add a new test size to avoid the PSPModule pooling size of 1x1 in PSPNet/UPerNet from triggering a PyTorch nn.BatchNorm2d size error.

@qubvel qubvel merged commit 8380b15 into qubvel-org:main Oct 12, 2024
11 checks passed
@qubvel
Copy link
Collaborator

qubvel commented Oct 12, 2024

Thanks a lot for contribution!

@brianhou0208 brianhou0208 deleted the fix_test_model branch October 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants