-
Notifications
You must be signed in to change notification settings - Fork 254
add a note on extracting multiline processing in comprehensions #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
graingert
wants to merge
2
commits into
quantifiedcode:master
Choose a base branch
from
graingert:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
Using ``map()`` or ``filter()`` where list comprehension is possible | ||
==================================================================== | ||
Using ``map()`` or ``filter()`` | ||
=============================== | ||
|
||
For transformations that can be expressed as a list comprehension, use list comprehensions over ``map()`` or ``filter()``. Although a ``map()`` or ``filter()`` expression may be functionally equivalent to a list comprehension, the list comprehension is more concise and easier to read. For expressions that are too long or complicated to express directly within a comprehension extract them into a function. | ||
|
||
For simple transformations that can be expressed as a list comprehension, use list comprehensions over ``map()`` or ``filter()``. Although a ``map()`` or ``filter()`` expression may be functionally equivalent to a list comprehension, the list comprehension is generally more concise and easier to read. | ||
|
||
Anti-pattern | ||
------------ | ||
|
@@ -26,6 +27,20 @@ In the modified code below, the code uses a list comprehension to generate the s | |
values = [1, 2, 3] | ||
doubles = [x * 2 for x in values] | ||
|
||
Sometimes a condition or process is too complicated or impossible to express in a single expression, for those extract them to a function and use a comprehension: | ||
|
||
.. code:: python | ||
|
||
def process(v): | ||
if v.ham == "spam": | ||
return 4 | ||
if v.bacon == "eggs" | ||
return 7 | ||
|
||
def cond(v): ... | ||
|
||
[process(x) for x in items if cond(v)] # preferable to map(process, filter(cond, items)) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how about also a note on how to combine cond and process? Sometimes a condition or process may repeat computation unnecessarily, in those cases extract a function that returns an iterable with the result or an empty iterable:
.. code:: python
hams = [x["ham"] for x in items if "ham" in x] # duplicate key lookup
.. code:: python
def process(x):
try:
return (x["ham"],)
except KeyError:
return ()
hams = [ham for x in items for ham in process(x)] There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's also often possible to inline this empty iterable into the comprehension
.. code:: python
hams = [x["ham"] for x in items if x.get("ham") is not None] # duplicated key lookup
.. code:: python
hams = [
ham
for x in items
for ham in (x.get("ham"),)
if ham is not None
]
and alternative in python 3.8+ is
.. code:: python
hams = [
ham
for x in items
if (ham := x.get("ham")) is not None
] |
||
References | ||
---------- | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.