Skip to content

Don't assign to in-built function in example #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Don't assign to in-built function in example #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/correctness/else_clause_on_loop_without_a_break_statement.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ The code below demonstrates some potential unintended behavior that can result w

.. code:: python

def contains_magic_number(list, magic_number):
for i in list:
def contains_magic_number(numbers, magic_number):
for i in numbers:
if i == magic_number:
print("This list contains the magic number")
else:
Expand All @@ -31,8 +31,8 @@ If the ``else`` clause should not always execute at the end of a loop clause, th

.. code:: python

def contains_magic_number(list, magic_number):
for i in list:
def contains_magic_number(numbers, magic_number):
for i in numbers:
if i == magic_number:
print("This list contains the magic number.")
# added break statement here
Expand Down