-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate to DuckDB 1.1.0 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@carlopi might need some help with this 🙏 grazie in anticipo |
Hi, I think to actually test this you would also need, as part of this PR, to change
(note |
@carlopi i'm totally lost in API changes, currently broken builds due to .hpp mismatches |
@carlopi forgot to mention i'm testing using a fork of community-extensions which seems to correctly handle |
I can also take over later, I guess this and the original one from @Alex-Monahan will need the same fixes (so maybe Alex will get to do them before I have my chance??) |
Hi folks! I was able to make a PR for the scalar macro default changes and it was merged on DuckDB's main branch. Does that help here at all, or is there more that needs to be done? |
Hey @Alex-Monahan well I tried to follow the PR and failed so far - certainly my fault porting from your example I assume but still trying to understand, very possibly just related to the wrong headers being included in my attempts.... |
Hi Lorenzo! Since DuckDB 1.1 launches next week, I think that it is probably best to wait for that and retest. Once you upgrade to 1.1, there shouldn't be any cpp or hpp files to include a copy of in your extension - they will all be in the duckdb git submodule. I tested this with my own extension and upgrading the duckdb submodule to the main branch (and doing a git pull) instead of 1.0.0 was enough to get things going for me! If you wouldn't mind, could you retest with 1.1.0 and then let me know if you encounter any issues? Thanks! |
Thank you so much @Alex-Monahan and @carlopi we're back on track with 1.1.0 🎉 |
Adding default parameters to scalar macros defined as a DefaultMacro