Skip to content

Migrate to DuckDB 1.1.0 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 9, 2024
Merged

Migrate to DuckDB 1.1.0 #10

merged 15 commits into from
Sep 9, 2024

Conversation

lmangani
Copy link
Collaborator

Adding default parameters to scalar macros defined as a DefaultMacro

@lmangani lmangani changed the title WIP: Update chsql_extension.cpp WIP: Prepare for 1.1.0 Aug 30, 2024
@lmangani
Copy link
Collaborator Author

@carlopi might need some help with this 🙏 grazie in anticipo

@carlopi
Copy link

carlopi commented Sep 4, 2024

Hi, I think to actually test this you would also need, as part of this PR, to change .github/workflows/MainDistributionPipeline.yml so that the core part looks like:

  duckdb-stable-build:
    name: Build extension binaries
    uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
    with:
      duckdb_version: main
      extension_name: chsql

  duckdb-stable-deploy:
    name: Deploy extension binaries
    needs: duckdb-stable-build
    uses: duckdb/extension-ci-tools/.github/workflows/_extension_deploy.yml@main
    secrets: inherit
    with:
      duckdb_version: main
      extension_name: chsql
      deploy_latest: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
      deploy_versioned: ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}

(note main instead of v1.0.0)
Alternatively you can set on a specific commit (say latest nigthly build, 1e883cd4d87d812166d035e180145a85c608ad6f)

@lmangani
Copy link
Collaborator Author

lmangani commented Sep 4, 2024

@carlopi i'm totally lost in API changes, currently broken builds due to .hpp mismatches

@lmangani
Copy link
Collaborator Author

lmangani commented Sep 4, 2024

@carlopi forgot to mention i'm testing using a fork of community-extensions which seems to correctly handle ref_next (and failing due to issues in this PR)

@carlopi
Copy link

carlopi commented Sep 4, 2024

I can also take over later, I guess this and the original one from @Alex-Monahan will need the same fixes (so maybe Alex will get to do them before I have my chance??)

@Alex-Monahan
Copy link
Contributor

Hi folks! I was able to make a PR for the scalar macro default changes and it was merged on DuckDB's main branch. Does that help here at all, or is there more that needs to be done?

duckdb/duckdb#13494

@lmangani
Copy link
Collaborator Author

lmangani commented Sep 4, 2024

Hi folks! I was able to make a PR for the scalar macro default changes and it was merged on DuckDB's main branch. Does that help here at all, or is there more that needs to be done?

duckdb/duckdb#13494

Hey @Alex-Monahan well I tried to follow the PR and failed so far - certainly my fault porting from your example I assume but still trying to understand, very possibly just related to the wrong headers being included in my attempts....

@Alex-Monahan
Copy link
Contributor

Hi Lorenzo!

Since DuckDB 1.1 launches next week, I think that it is probably best to wait for that and retest. Once you upgrade to 1.1, there shouldn't be any cpp or hpp files to include a copy of in your extension - they will all be in the duckdb git submodule.

I tested this with my own extension and upgrading the duckdb submodule to the main branch (and doing a git pull) instead of 1.0.0 was enough to get things going for me!

If you wouldn't mind, could you retest with 1.1.0 and then let me know if you encounter any issues?

Thanks!
-Alex

@lmangani lmangani changed the title WIP: Prepare for 1.1.0 Migrate to DuckDB 1.1.0 Sep 9, 2024
@lmangani lmangani marked this pull request as ready for review September 9, 2024 16:57
@lmangani
Copy link
Collaborator Author

lmangani commented Sep 9, 2024

Thank you so much @Alex-Monahan and @carlopi we're back on track with 1.1.0 🎉

@lmangani lmangani merged commit db79a6b into main Sep 9, 2024
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants