Skip to content

Update links in RPC tutorial #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2021
Merged

Update links in RPC tutorial #946

merged 3 commits into from
Apr 23, 2021

Conversation

mrshenli
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Apr 11, 2020 •
edited
Loading

Deploy preview for pytorch-tutorials-preview ready!

Built with commit a0adb7a

https://deploy-preview-946--pytorch-tutorials-preview.netlify.app

@mrshenli
Copy link
Contributor Author

hey @jlin27 @rohan-varma, I noticed that the url has changed in master compared to stable.

master: master/rpc/rpc.html
stable: stable/rpc.html

Does this mean we should update all links in tutorial?

@rohan-varma
Copy link
Member

I think that the difference is master will always show the latest docs (i.e. the ones that are landed to master), stable will show the ones corresponding to the current release. Given that we want to release Dist RPC framework as stable, I think we should do this update. cc @jlin27

@abitrolly
Copy link

Looks like this got stalled because of branch conflict.

@mrshenli
Copy link
Contributor Author

mrshenli commented Aug 3, 2020

My bad, will create a new one to fix links and also add links to DDP + RPC and autograd profiler.

Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
@holly1238 holly1238 merged commit 4c48624 into pytorch:master Apr 23, 2021
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@mrshenli @holly1238
Update links in RPC tutorial (pytorch#946)
a7c7e37 
Co-authored-by: Shen Li <shenli@devfair017.maas>
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-varma rohan-varma rohan-varma approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrshenli @rohan-varma @abitrolly @facebook-github-bot @holly1238