-
Notifications
You must be signed in to change notification settings - Fork 4.2k
improve readability of the cifar10 blitz tutorial code #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for pytorch-tutorials-preview ready! Built with commit 84ef498 https://deploy-preview-849--pytorch-tutorials-preview.netlify.com |
Deploy preview for pytorch-tutorials-preview ready! Built with commit ca8fb70 https://deploy-preview-849--pytorch-tutorials-preview.netlify.app |
Hi @wAuner! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Hi @wAuner! Can you sign the CLA agreement so that I can merge the pull request? Thanks! |
@holly1238 if it's not some 100 page document written in legal Klingon, then yes 😄 |
@holly1238 ok I've signed that cla. Maybe the check needs to be triggered again |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
When I was working through the blitz cifar 10 tutorial it took me quite some time to understand the evaluation logic of the per-class accuracy.
I've added some code comments and rewrote this small part to make it much more obvious what is going on. Generally I've tried to replace the
range
s with fixed numbers for batchsize or classes with speaking names.In detail: