Update 'Was this Helpful?' tracking #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 7fe5844 https://deploy-preview-845--pytorch-tutorials-preview.netlify.com |
brucejlin1
approved these changes
Feb 9, 2020
brianjo
reviewed
Feb 11, 2020
There was a problem hiding this comment.
Hey Pat, could you make any edit to this file so I can trigger a rebase on it. When it passes tests I'll merge it. (There was an update to pandas that broke the build and I needed to fix that this morning. For some reason the option to rebase this particular PR doesn't show up in my UI and I'm hoping that if you make a change to the file I can kick that in.) Thanks!
patmellon
force-pushed
the
was-this-helpful-tracking
branch
from
dbd3fe2 to
e4368f0
Compare
patmellon
force-pushed
the
was-this-helpful-tracking
branch
from
e4368f0 to
7fe5844
Compare
|
@brianjo Sounds good. I just updated the PR. |
Thanks Pat! Will merge after the tests pass. |
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
Update 'Was this Helpful?' tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the event tracking for the "Was this Helpful?" button. It uses a different tracking ID and updates the way the data is sent to analytics.