-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Reinstate torchaudio tutorial #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate torchaudio tutorial #687
Conversation
Deploy preview for pytorch-tutorials-preview ready! Built with commit 0b5aa0d https://deploy-preview-687--pytorch-tutorials-preview.netlify.com |
Thanks @vincentqb! I'll make sure this is merged as soon as the Will hold off on merging until the new tutorials we're releasing today are merged, though. |
@SethHWeidman -- I'd like to see if the latest version of torchaudio fixes the original issue. However, I see a lot of tests with "ci/circleci: pytorch_tutorial_build_manager Expected — Waiting for status to be reported" that are not running. Is that expected? |
Hey @vincentqb, I can re-run those build scripts in Circle since I'm an admin of this repo, no prob. However, I'm still getting the same error when I |
99a4d08
to
32b83bc
Compare
As mentioned in #307, I am unable to reproduce the error. I've pinged you offline :) |
32b83bc
to
cd5b3a9
Compare
Ok, trying this - I do hope it works!! Will re-add the audio tutorial if so. I suspect that it won't though: the reason is our tutorials Is it possible we've fixed the issue on a development version of |
We're still getting the error when importing |
Indeed. The version on pip needs to be updated to 0.3.1, here. If this is indeed the issue, I would expect an error in the logs about incompatible versions though. |
The version seems to be the problem. In linux:
|
Great, @vincentqb, then at least we know the fix: let's get version 0.3.1 on PyPi! |
Reinstate audio tutorial. This reverts commit 9cee825.
86e6064
to
47af5dc
Compare
The code snippet now works.
Let's see if the tests pass. |
@vincentqb merging! @ezyang, to prevent this kind of thing from happening in the future, let's make sure we release versions of the domain libraries to PyPi along with our major releases. |
Reinstate torchaudio tutorial
Let's see if the tutorial loads correctly with current binaries. pytorch/audio#307
This partly reverts commit 9cee825 from #685.
CC @SethHWeidman @ezyang