Skip to content

Reinstate torchaudio tutorial #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Oct 10, 2019

Let's see if the tutorial loads correctly with current binaries. pytorch/audio#307

This partly reverts commit 9cee825 from #685.

CC @SethHWeidman @ezyang

@netlify
Copy link

netlify bot commented Oct 10, 2019

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 0b5aa0d

https://deploy-preview-687--pytorch-tutorials-preview.netlify.com

@SethHWeidman
Copy link
Contributor

Thanks @vincentqb! I'll make sure this is merged as soon as the torchaudio issue is fixed. Glad you were able to reproduce that one.

Will hold off on merging until the new tutorials we're releasing today are merged, though.

@vincentqb
Copy link
Contributor Author

@SethHWeidman -- I'd like to see if the latest version of torchaudio fixes the original issue. However, I see a lot of tests with "ci/circleci: pytorch_tutorial_build_manager Expected — Waiting for status to be reported" that are not running. Is that expected?

@SethHWeidman
Copy link
Contributor

Hey @vincentqb, I can re-run those build scripts in Circle since I'm an admin of this repo, no prob.

However, I'm still getting the same error when I import torchaudio if I have version >=1.3.0 of torch installed. Are you able to reproduce this? If not I can walk through with you on a VC.

@vincentqb vincentqb force-pushed the reinstate-tutorial-audio branch from 99a4d08 to 32b83bc Compare October 15, 2019 20:05
@vincentqb
Copy link
Contributor Author

vincentqb commented Oct 15, 2019

Hey @vincentqb, I can re-run those build scripts in Circle since I'm an admin of this repo, no prob.

However, I'm still getting the same error when I import torchaudio if I have version >=1.3.0 of torch installed. Are you able to reproduce this? If not I can walk through with you on a VC.

As mentioned in #307, I am unable to reproduce the error. I've pinged you offline :)

@vincentqb vincentqb force-pushed the reinstate-tutorial-audio branch from 32b83bc to cd5b3a9 Compare October 15, 2019 20:09
@SethHWeidman
Copy link
Contributor

SethHWeidman commented Oct 15, 2019

Ok, trying this - I do hope it works!! Will re-add the audio tutorial if so.

I suspect that it won't though: the reason is our tutorials pip install all the libraries in requirements.txt before running the code in the tutorials; and when I pip install torchaudio locally (or on my devserver), pip still force uninstalls torch 1.3.0 and installs torch 1.2.0 instead.

Is it possible we've fixed the issue on a development version of torchaudio, but not the version that is on PyPi? Seems to me like that version is still incompatible with torch 1.3.0.

@SethHWeidman
Copy link
Contributor

We're still getting the error when importing torchaudio: https://circleci.com/gh/pytorch/tutorials/18830

@vincentqb vincentqb changed the title Revert "Remove problematic tutorials" Reinstate torchaudio tutorial Oct 16, 2019
@vincentqb
Copy link
Contributor Author

vincentqb commented Oct 16, 2019

I suspect that it won't though: the reason is our tutorials pip install all the libraries in requirements.txt before running the code in the tutorials; and when I pip install torchaudio locally (or on my devserver), pip still force uninstalls torch 1.3.0 and installs torch 1.2.0 instead.

Is it possible we've fixed the issue on a development version of torchaudio, but not the version that is on PyPi? Seems to me like that version is still incompatible with torch 1.3.0.

Indeed. The version on pip needs to be updated to 0.3.1, here. If this is indeed the issue, I would expect an error in the logs about incompatible versions though.

@vincentqb
Copy link
Contributor Author

vincentqb commented Oct 16, 2019

The version seems to be the problem. In linux:

conda create -n pytorch-pip python=3.7
conda activate pytorch-pip
pip install torchaudio
python -c "import torchaudio"
# success

pip install torch==1.3.0
# upgrades torch from 1.2.0 to 1.3.0 with a warning
python -c "import torchaudio"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/private/home/vincentqb/anaconda3/envs/pytorch-pip/lib/python3.7/site-packages/torchaudio/__init__.py", line 5, in <module>
    import _torch_sox
ImportError: /private/home/vincentqb/anaconda3/envs/pytorch-pip/lib/python3.7/site-packages/_torch_sox.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN3c1012CUDATensorIdEv

@SethHWeidman
Copy link
Contributor

Great, @vincentqb, then at least we know the fix: let's get version 0.3.1 on PyPi!

Reinstate audio tutorial.

This reverts commit 9cee825.
@vincentqb vincentqb force-pushed the reinstate-tutorial-audio branch from 86e6064 to 47af5dc Compare October 17, 2019 14:13
@vincentqb
Copy link
Contributor Author

The code snippet now works.

conda create -n pytorch-pip python=3.7
conda activate pytorch-pip
pip install torchaudio
python -c "import torchaudio"
# success

pip install torch==1.3.0
# already satisfied

Let's see if the tests pass.

@SethHWeidman
Copy link
Contributor

@vincentqb merging!

@ezyang, to prevent this kind of thing from happening in the future, let's make sure we release versions of the domain libraries to PyPi along with our major releases.

@SethHWeidman SethHWeidman merged commit 5fdf751 into pytorch:master Oct 21, 2019
@vincentqb vincentqb deleted the reinstate-tutorial-audio branch October 22, 2019 15:08
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants