Use PackedTensorAccessor32 in cpp extension tutorial #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 07839ae https://deploy-preview-644--pytorch-tutorials-preview.netlify.com |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 10, 2019
Summary: Closes #19268 This does the renaming suggested by ezyang in #19268 (comment) except that the templated version of `packed_accessor` is also renamed to `generic_packed_accessor`. Additionally, all of the users I could find in `ATen/native/cuda` are updated without changing their index types. The corresponding tutorial update is in pytorch/tutorials#644 Pull Request resolved: #25654 Differential Revision: D17259208 Pulled By: ezyang fbshipit-source-id: 172a46f623d544ca16f7ed5077b6e4f57a3d1f21
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 10, 2019
Summary: Closes pytorch/pytorch#19268 This does the renaming suggested by ezyang in pytorch/pytorch#19268 (comment) except that the templated version of `packed_accessor` is also renamed to `generic_packed_accessor`. Additionally, all of the users I could find in `ATen/native/cuda` are updated without changing their index types. The corresponding tutorial update is in pytorch/tutorials#644 Pull Request resolved: pytorch/pytorch#25654 Differential Revision: D17259208 Pulled By: ezyang fbshipit-source-id: 172a46f623d544ca16f7ed5077b6e4f57a3d1f21
ezyang
approved these changes
Sep 30, 2019
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
Use PackedTensorAccessor32 in cpp extension tutorial
|
Nit - the tutorial refers to code that's different from the tutorial as it was changed in this PR; https://github.com/pytorch/extension-cpp/blob/master/cuda/lltm_cuda_kernel.cu eg in my copy-pasta i suddenly ended up with the legacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes pytorch/pytorch#19268
See pytorch/pytorch#25654 for the corresponding renaming of
PackedTensorAccessor.