Skip to content

change the get_screen method so that it does not fill the gpu memory #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

andreistirb
Copy link
Contributor

I changed the get_screen method so that it does not copy the tensor to GPU device at the return point of the method. If we copy the tensor each and every time to the device at some point we would fill the memory with unnecessary data.
Also, in order for this to work I changed the forward method from the DQN object so that it copies the input to device before doing any other stuff.

@netlify
Copy link

netlify bot commented Jan 15, 2019

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 24a53a5

https://deploy-preview-415--pytorch-tutorials-preview.netlify.app

@soumith
Copy link
Member

soumith commented Jan 15, 2019

cc: @mike7ant

Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
@facebook-github-bot
Copy link
Contributor

Hi @andreistirb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@holly1238
Copy link
Contributor

Hi @andreistirb! Can you sign the CLA agreement so that I can merge the pull request? Thanks!

@andreistirb
Copy link
Contributor Author

Hello @holly1238, I have completed the form, thank you for accepting my contribution!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@holly1238 holly1238 merged commit 72b6df1 into pytorch:master Apr 26, 2021
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
…ytorch#415)

Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants