Skip to content

Add notes about supported custom ops input types #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Add notes about supported custom ops input types #388

merged 1 commit into from
Dec 17, 2018

Conversation

sidazhang
Copy link

Custom ops only support a subset of types. Adding some notes about what is supported.

soumith
soumith approved these changes Dec 17, 2018
View reviewed changes
advanced_source/torch_script_custom_ops.rst


FAQ
---------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @suo

@suo I'm going to merge this in, please make sure you update this when we add support for any more types.

@soumith soumith merged commit 4779db8 into pytorch:master Dec 17, 2018
@soumith
Copy link
Member

soumith commented Dec 17, 2018

thanks @sidazhang !

rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@soumith
Merge pull request pytorch#388 from sidazhang/type_notes
45c722c 
Add notes about supported custom ops input types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumith soumith soumith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidazhang @soumith