-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update torch.compile tutorial #3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3363
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4c42f51 with merge base 85739f5 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc: @AlannaBurke can you please take a look when you get the chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview isn't working for the second tutorial, but it looks ok aside from being able to check formatting.
**Author:** William Wen | ||
""" | ||
|
||
import warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want this showing at the top like it is? It doesn't make much sense in the flow of the page.
# | ||
# This tutorial covers an end-to-end example of training and evaluating a | ||
# real model with ``torch.compile``. For a gentler introduction to ``torch.compile``, | ||
# please check out our ```torch.compile`` tutorial <https://pytorch.org/tutorials/intermediate/torch_compile_tutorial.html>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix link format
# | ||
# We remark that the speedup numbers presented in this tutorial are for | ||
# demonstration purposes only. Official speedup values can be seen at the | ||
# `TorchInductor performance dashboard <https://hud.pytorch.org/benchmark/compilers>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a conclusion here.
# | ||
# - ``torch >= 2.0`` | ||
# - ``torchvision`` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add What you will learn and Prerequisites and follow the template: https://github.com/pytorch/tutorials/blob/main/beginner_source/template_tutorial.py
``torch.compile`` End-to-End Tutorial | ||
================================= | ||
**Author:** William Wen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the index.rst
Update torch.compile tutorial for 2.8/new torch.compile programming model