Skip to content

change torch.cuda.amp.GradScaler to torch.GradScaler("cuda") #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2025
Merged

change torch.cuda.amp.GradScaler to torch.GradScaler("cuda") #3257

merged 4 commits into from
Jan 30, 2025

Conversation

0ssamaak0
Copy link
Contributor

Description

using torch.cuda.amp.GradScaler will result in a warning

FutureWarning: `torch.cuda.amp.GradScaler(args...)` is deprecated. Please use `torch.amp.GradScaler('cuda', args...)` instead.

So it should be changed according to Automatic Mixed Precision package Documentation torch.cuda.amp.GradScaler to torch.GradScaler("cuda") to match

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3257

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 50173b2 with merge base 15ef015 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @0ssamaak0!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

spzala
spzala reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments inline. Thanks!

recipes_source/recipes/amp_recipe.py Outdated
@@ -182,7 +182,7 @@ def make_model(in_size, out_size, num_layers):

net = make_model(in_size, out_size, num_layers)
opt = torch.optim.SGD(net.parameters(), lr=0.001)
scaler = torch.cuda.amp.GradScaler(enabled=use_amp)
scaler = torch.GradScaler("cuda" ,enabled=use_amp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed this
image

Source

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reply. GradScaler can be used on its own but because you are modifying amp recipe, I would suggest to use torch.amp.GradScaler as it's also mentioned in the code - https://github.com/pytorch/pytorch/blob/main/torch/cuda/amp/grad_scaler.py#L12
Also, if you run the recipe, you will notice the warning message suggesting to use torch.amp.GradScaler

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the code accordingly.

Thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svekars svekars added CUDA Issues relating to CUDA amp Issues relating to the automatic mixed precision tutorial labels Jan 27, 2025
malfet
malfet approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, thank you for the update

@malfet malfet merged commit 0a93a8b into pytorch:main Jan 30, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala left review comments

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
amp Issues relating to the automatic mixed precision tutorial cla signed CUDA Issues relating to CUDA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0ssamaak0 @facebook-github-bot @malfet @spzala @svekars