Skip to content

Fix torchrl scripts for PT 2.6 / TorchRL>=0.6 #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Dec 20, 2024

Fixes #3195
Fixing TorchRL scripts for Pytorch 2.6 release

Copy link

pytorch-bot bot commented Dec 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3199

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 727a4ab with merge base 7262c21 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars
Copy link
Contributor

svekars commented Dec 20, 2024

Thank you Vincent, can you reenable the ppo and pendulum tutorials: https://github.com/pytorch/tutorials/blob/2.6-RC-TEST/.jenkins/validate_tutorials_built.py#L56-L57

@vmoens vmoens force-pushed the fix-torchrl-scripts branch from fe0e824 to 727a4ab Compare December 20, 2024 17:48
@vmoens
Copy link
Contributor Author

vmoens commented Dec 20, 2024

@svekars Added!

@svekars svekars added the rl Issues related to reinforcement learning tutorial, DQN, and so on label Dec 20, 2024
@svekars svekars merged commit 39d3e6e into 2.6-RC-TEST Dec 20, 2024
19 checks passed
@svekars svekars deleted the fix-torchrl-scripts branch December 20, 2024 19:04
mikaylagawarecki pushed a commit to mikaylagawarecki/tutorials that referenced this pull request Jan 24, 2025
Fixes pytorch#3195
Fixing TorchRL scripts for Pytorch 2.6 release
svekars pushed a commit that referenced this pull request Jan 27, 2025
Fixes #3195
Fixing TorchRL scripts for Pytorch 2.6 release
titaiwangms pushed a commit to titaiwangms/tutorials that referenced this pull request Jan 27, 2025
Fixes pytorch#3195
Fixing TorchRL scripts for Pytorch 2.6 release
svekars added a commit that referenced this pull request Jan 27, 2025
Fixes #3195
Fixing TorchRL scripts for Pytorch 2.6 release

Co-authored-by: Vincent Moens <vmoens@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants