Skip to content

[FR][tutorial] Minor fix #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

[FR][tutorial] Minor fix #3081

merged 3 commits into from
Oct 9, 2024

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Oct 7, 2024

Summary:
Don't interrupt user's flow that they may need to install tabulate. Also, show them the actual command that they need to run to install tabulate.
This was feedback from @lessw2020.

Test Plan:
Look at rendered doc.

Fixes #ISSUE_NUMBER

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@c-p-i-o c-p-i-o self-assigned this Oct 7, 2024
Copy link

pytorch-bot bot commented Oct 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3081

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b3bf410 with merge base 31eb1da (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@c-p-i-o c-p-i-o force-pushed the cpio/flight_recorder_2 branch from 0b68778 to 439e9b3 Compare October 7, 2024 22:38
Summary:
Don't interrupt user's flow that they may need to install `tabulate`.
Also, show them the actual command that they need to run to install
`tabulate`.

Add this to the prereqisite section.

Test Plan:
Look at rendered doc.
@c-p-i-o c-p-i-o force-pushed the cpio/flight_recorder_2 branch from 439e9b3 to 58fc3a0 Compare October 7, 2024 22:38
@c-p-i-o c-p-i-o requested a review from svekars October 7, 2024 22:39
@svekars svekars merged commit 85caa62 into main Oct 9, 2024
19 checks passed
@svekars svekars deleted the cpio/flight_recorder_2 branch October 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants