Skip to content

Regional compilation recipe #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 10, 2024
Merged

Regional compilation recipe #3070

merged 9 commits into from
Oct 10, 2024

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Sep 30, 2024 •
edited by pytorch-bot bot
Loading

Fixes #ISSUE_NUMBER

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @williamwen42 @msaroufim

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3070

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6679a07 with merge base 4b22e03 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305
Copy link
Contributor Author

cc @oulgen @ezyang for review.

svekars
svekars reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I did an editorial pass - let me know if you have any questions.

recipes_source/recipes/regional_compilation.py Outdated
# are continually working on reducing cold start compilation time. So, please
# stay tuned for our next tutorials.
#
# This feature is available with 2.5 release. If you are on 2.4, you can use a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could say this in the beginning of the tutorial

@svekars svekars added the 2.5 PR related to version 2.5 label Oct 1, 2024
svekars
svekars reviewed Oct 1, 2024
View reviewed changes
@svekars svekars added the torch.compile Torch compile and other relevant tutorials label Oct 1, 2024
svekars
svekars reviewed Oct 1, 2024
View reviewed changes
svekars
svekars reviewed Oct 1, 2024
View reviewed changes
svekars
svekars reviewed Oct 1, 2024
View reviewed changes
oulgen
oulgen approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

svekars
svekars approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge 1 week before the release

@svekars svekars merged commit e68eb41 into pytorch:main Oct 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oulgen oulgen oulgen approved these changes

@svekars svekars svekars approved these changes

Assignees
No one assigned
Labels
2.5 PR related to version 2.5 cla signed torch.compile Torch compile and other relevant tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anijain2305 @oulgen @svekars @facebook-github-bot