Skip to content

Minor fixes #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2024
Merged

Minor fixes #3059

merged 2 commits into from
Sep 24, 2024

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Sep 23, 2024 •
edited
Loading

Summary:

  1. Move FILE option to "Optional settings" section.
  2. Add a link to how customer can add a DebugInfoWriter.
  3. Clarify a sentence.

Test Plan:
Test manually.

Reviewers:

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@c-p-i-o
Minor fixes
9b2ee3c 
Summary:
1. Move FILE option to "Optional settings" section.
2. Add a link.
3. Clarify a sentence.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3059

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit af56546 with merge base cd7f684 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@c-p-i-o c-p-i-o self-assigned this Sep 23, 2024
@c-p-i-o c-p-i-o marked this pull request as ready for review September 23, 2024 22:57
@c-p-i-o c-p-i-o requested a review from fduwjj September 23, 2024 22:57
c-p-i-o
c-p-i-o commented Sep 23, 2024
View reviewed changes
fduwjj
fduwjj reviewed Sep 23, 2024
View reviewed changes
fduwjj
fduwjj reviewed Sep 23, 2024
View reviewed changes
fduwjj
fduwjj approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, my only ask here is maybe let's still keep the file ENV not optional?

@c-p-i-o c-p-i-o merged commit 4126761 into main Sep 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

Assignees

@c-p-i-o c-p-i-o

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-p-i-o @fduwjj @facebook-github-bot