Skip to content

Remove sphinx theme from .gitmodules #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Remove sphinx theme from .gitmodules #3038

merged 1 commit into from
Sep 6, 2024

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Sep 5, 2024

Because we import the theme here, we don't really need it as a submodule. It also seem to generate some unneeded paths in the sitemap.

Copy link

pytorch-bot bot commented Sep 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3038

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d25bb3 with merge base c2a8800 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars marked this pull request as ready for review September 6, 2024 15:24
@svekars svekars added the build issue Issues relating to the tutorials build label Sep 6, 2024
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@svekars svekars merged commit 23a9aa0 into main Sep 6, 2024
19 checks passed
@svekars svekars deleted the svekars-patch-28 branch September 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build issue Issues relating to the tutorials build cla signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants