Skip to content

[Tensor Parallel] remove non-existing code pointer #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Aug 15, 2024

Stack from ghstack (oldest at bottom):

This PR removes the non-existing code pointer, which caused confusion for readers e.g. #2956

Copy link

pytorch-bot bot commented Aug 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2998

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3a3e027 with merge base f1c0b8a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

tianyu-l added a commit that referenced this pull request Aug 15, 2024
ghstack-source-id: 885ed33
Pull Request resolved: #2998
tianyu-l added a commit that referenced this pull request Aug 15, 2024
ghstack-source-id: 533d9b7
Pull Request resolved: #2998
@tianyu-l tianyu-l requested review from wanchaol and svekars August 15, 2024 22:07
@svekars
Copy link
Contributor

svekars commented Aug 15, 2024

Thanks so much for the PR and looks good but we don't support gh-stack in this repo - it won't merge. Can you please resubmit as a regular PR - and I'll be happy to merge it

@tianyu-l
Copy link
Contributor Author

@svekars got it, created another PR #3000

@tianyu-l tianyu-l closed this Aug 16, 2024
svekars pushed a commit that referenced this pull request Aug 19, 2024
svekars pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants