Skip to content

Fix torchrl and tensordict requirements #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .ci/docker/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ tensorboard
jinja2==3.1.3
pytorch-lightning
torchx
# TODO: use stable 0.5 when released
-e git+https://github.com/pytorch/rl.git#egg=torchrl
-e git+https://github.com/pytorch/tensordict.git#egg=tensordict
torchrl==0.5.0
tensordict==0.5.0
ax-platform>==0.4.0
nbformat>==5.9.2
datasets
Expand Down
2 changes: 1 addition & 1 deletion intermediate_source/pinmem_nonblock.py
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ def pin_copy_to_device_nonblocking(*tensors):
# CUDA-enabled device.
#
# In summary, copying data from CPU to GPU is safe when using ``non_blocking=True``, but for any other direction,
# ``non_blocking=True`` can still be used but the user must make sure that a device synchronization is executed after
# ``non_blocking=True`` can still be used but the user must make sure that a device synchronization is executed before
# the data is accessed.
#
# Practical recommendations
Expand Down
Loading