Skip to content

updated FSDP tutorial #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

surprisedPikachu007
Copy link
Contributor

@surprisedPikachu007 surprisedPikachu007 commented Jul 18, 2024

Description

replace fsdp_auto_wrap_policy with auto_wrap_policy

cc @wconstab @osalpekar @H-Huang @kwen2501

Copy link

pytorch-bot bot commented Jul 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2975

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4c6d7c6 with merge base db6cf8e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@surprisedPikachu007
Copy link
Contributor Author

@svekars can you review the changes?

@svekars svekars requested a review from lessw2020 July 29, 2024 20:08
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thanks for the update.

@svekars svekars merged commit c3882db into pytorch:main Jul 29, 2024
13 checks passed
@surprisedPikachu007 surprisedPikachu007 deleted the fsdp-tutorial-update branch July 30, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants