Update CONTRIBUTING.md #2747
Merged
Update CONTRIBUTING.md #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update managing data to ask users to put data download logic to download.py instead of Makefile.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2747
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed44b5e with merge base d9a0d6b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Looks good to me, and I see we've been recommending this. Adding a nit comment. |
brycebortree
approved these changes
Jan 26, 2024
CONTRIBUTING.md
Outdated
| required data files. | ||
|
|
||
| To download your data add a function to the [download.py](https://github.com/pytorch/tutorials/blob/main/.jenkins/download_data.py) | ||
| script. Follow the same patern as other download functions. |
svekars
added a commit
that referenced
this pull request
Feb 2, 2024
* Update CONTRIBUTING.md Update managing data to ask users to put data download logic to download.py instead of Makefile. * Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Managing Data section of CONTRIBUTING.m to ask users put data download logic to download.py instead of Makefile.