Skip to content

Add FSDP reference in PyTorch Distributed doc #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

spzala
Copy link
Contributor

@spzala spzala commented Jan 22, 2024

PyTorch Distributed Overview page
is widely used to learn basics of distributed package and its offerings.

Description

Seems like this page on PyTorch Distributed Overview was created before the FSDP support was added in PyTorch. This PR adds missing FSDP reference.

Checklist

  • [ x] The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • [ x] Only one issue is addressed in this pull request
  • [ ]x Labels from the issue that this PR is fixing are added to this pull request
  • [ x] No unnecessary issues are included into this pull request.

cc @wconstab @osalpekar @H-Huang @kwen2501

Copy link

pytorch-bot bot commented Jan 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2738

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9cc665b with merge base c703e69 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@spzala
Copy link
Contributor Author

spzala commented Jan 22, 2024

cc @svekars @subramen

@svekars
Copy link
Contributor

svekars commented Jan 22, 2024

Can you please add FSDP to the en-wordlist.txt to fix spellcheck.

PyTorch Distributed Overview page
(https://pytorch.org/tutorials/beginner/dist_overview.html)
is widely used to learn basics of distributed package and its
offerings. Seems like this page was created before the  FSDP
support was added in PyTorch. This PR adds missing FSDP reference.
@spzala
Copy link
Contributor Author

spzala commented Jan 22, 2024

Can you please FSDP to the en-wordlist.txt to fix spellcheck.

Ah :) sure, done. Thank you! @svekars

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@svekars svekars merged commit f3c4ed7 into pytorch:main Jan 22, 2024
@spzala
Copy link
Contributor Author

spzala commented Jan 22, 2024

LGTM! Thank you!

Thank you @svekars !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants